Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect _local 404 detection in P2P scenario #601

Closed
borrrden opened this issue Mar 1, 2016 · 1 comment
Closed

Incorrect _local 404 detection in P2P scenario #601

borrrden opened this issue Mar 1, 2016 · 1 comment
Assignees
@borrrden
Labels
bug
Milestone
1.2.1

Comments

@borrrden
Copy link
Member

borrrden commented Mar 1, 2016

The exception throw is not HttpException, but HttpResponseException. Need to change that.
@borrrden borrrden self-assigned this Mar 1, 2016
@borrrden borrrden added this to the 1.3 milestone Mar 1, 2016
@borrrden borrrden removed this from the 1.3 milestone Mar 1, 2016
@borrrden borrrden added this to the 1.3 milestone Mar 1, 2016
@borrrden
Copy link
Member Author

borrrden commented Mar 1, 2016

Actually it was an AggregateException. The .NET provided Flatten() method will create a new AggregateException, as opposed to flattening it to one inner exception as I thought it would. Simple fix, but need to check other instances of Flatten() usage.

borrrden added a commit that referenced this issue Mar 1, 2016
@borrrden
Fixes #601
7098cab 
Fixes #602
@borrrden borrrden modified the milestones: 1.2.1, 1.3 Mar 4, 2016
borrrden added a commit that referenced this issue Mar 4, 2016
@borrrden
Fixes #601 Fixes #602
7708f82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@borrrden borrrden

Labels
bug
Projects
None yet
Milestone
1.2.1
Development

No branches or pull requests
1 participant
@borrrden