Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purge Document with ID and Set Expiration should allow to operate on deleted documents #1083

Closed
pasin opened this issue Nov 20, 2018 · 1 comment
Closed

Purge Document with ID and Set Expiration should allow to operate on deleted documents #1083

pasin opened this issue Nov 20, 2018 · 1 comment
Assignees
@Sandychuang8
Labels
P1: high
Milestone
2.5.0

Comments

@pasin
Copy link
Contributor

pasin commented Nov 20, 2018 •
edited
Loading

Library Version

Iridium

.NET Runtime

Any

Operating System / Device Details

Any

Expected behavior

Documents including deleted documents should allow to be purged or set expiration.

Actual behavior

Based on this and this, I understand that purging or setting expiration on deleted documents may not be working as GetDocument(doc) will return null for deleted documents?
@pasin pasin changed the title Purge Document with ID should allow to purge deleted document Purge Document with ID and Set Expiration should allow to operate on deleted documents Nov 20, 2018
@pasin pasin added this to the Iridium milestone Nov 20, 2018
@borrrden
Copy link
Member

@Sandychuang8 Please work with Pasin on this. The Purge call with document ID should use c4db_purgeDoc and it will probably be simpler to use the same for the normal case. Add tests to verify as well.

Sandychuang8 pushed a commit that referenced this issue Nov 21, 2018
#1082 #1083 add purge document
f9bd727
Sandychuang8 pushed a commit that referenced this issue Dec 6, 2018
#1082 #1083 add purge document
db34ba6
@borrrden borrrden removed the review label Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sandychuang8 Sandychuang8

Labels
P1: high
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
4 participants
@pasin @borrrden @Sandychuang8 @djpongh