Skip to content

Commit

Permalink
Merge pull request cockroachdb#20677 from justinj/emoji-in-name
Browse files Browse the repository at this point in the history
build: don't have test with emoji in its name
  • Loading branch information
justinj authored Dec 13, 2017
2 parents 01a8865 + 8608941 commit d796d03
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions pkg/util/json/json_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -215,12 +215,14 @@ func TestJSONRoundTrip(t *testing.T) {
// should be checked higher up.
string([]byte{'"', 0xa7, '"'}),
}
for _, tc := range testCases {
for i, tc := range testCases {
j, err := ParseJSON(tc)
if err != nil {
t.Fatal(err)
}
runDecodedAndEncoded(t, tc, j, func(t *testing.T, j JSON) {
// We don't include the actual string here because TeamCity doesn't handle
// test names with emojis in them well.
runDecodedAndEncoded(t, fmt.Sprintf("%d", i), j, func(t *testing.T, j JSON) {
s := j.String()

j2, err := ParseJSON(s)
Expand Down

0 comments on commit d796d03

Please sign in to comment.