Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to search result overflow #51

Merged
merged 2 commits into from
May 3, 2020

Conversation

karlsandin
Copy link
Contributor

Adds word break on search result page preamble, this bug is caused when using code markdown early in a post a can be seen in the screenshot below.

image

@cotes2020
Copy link
Owner

Sorry, I'm not sure what is meant by “when using code markdown early in the post”, could you please provide more details on how to reproduce the bug? (Maybe just paste a code snippet down below)

@karlsandin
Copy link
Contributor Author

Sure, sorry for being unclear! :)

If I create a post and add this code snippet as the first thing in the post the search result preamble/description will then add the snippet row number as one long word and therefore break the design.

Hope this made it a bit clearer!

// EmailInput wraps an HTML `input` and adds some app-specific styling.
const EmailInput = React.forwardRef((props, ref) => (
  <input ref={ref} {...props} type="email" className="AppEmailInput"></input>
));

class App extends Component {
  emailRef = React.createRef();

  // `this.emailRef.current` points to the `input` component inside of EmailInput,
  // because EmailInput is forwarding its ref via the `React.forwardRef` callback.
  onClickButton() {
    this.emailRef.current.focus();
  }

  render() {
    return (
      <div>
        <EmailInput ref={this.emailRef} />
        <button onClick={() => this.onClickButton()}>
          Click me to focus email
        </button>
      </div>
    );
  }
}

assets/css/main.scss Outdated Show resolved Hide resolved
@cotes2020
Copy link
Owner

cotes2020 commented May 3, 2020

I have combined your two commits into one (see 6fbebe3), thanks for the PR.

@cotes2020 cotes2020 merged commit 6fbebe3 into cotes2020:master May 3, 2020
cotes2020 added a commit that referenced this pull request May 5, 2020
Involves:
- Home page
- relate posts
- search results
- feed
cotes2020 added a commit that referenced this pull request May 8, 2020
Involves:
- Home page
- relate posts
- search results
- feed
@cotes2020 cotes2020 added this to the v2.2 milestone May 16, 2020
cotes2020 pushed a commit that referenced this pull request Sep 21, 2020
* Fix to search result overflow
cotes2020 added a commit that referenced this pull request Sep 21, 2020
Involves:
- Home page
- relate posts
- search results
- feed
mattpopovich referenced this pull request in mattpopovich/jekyll-theme-chirpy Oct 3, 2020
* Fix to search result overflow
mattpopovich referenced this pull request in mattpopovich/jekyll-theme-chirpy Oct 3, 2020
Involves:
- Home page
- relate posts
- search results
- feed
cotes2020 pushed a commit that referenced this pull request Oct 22, 2021
* Fix to search result overflow
cotes2020 added a commit that referenced this pull request Oct 22, 2021
Involves:
- Home page
- relate posts
- search results
- feed
sanjidnet pushed a commit to sanjidnet/sanjidnet.github.io that referenced this pull request Dec 26, 2023
* Fix to search result overflow
sanjidnet pushed a commit to sanjidnet/sanjidnet.github.io that referenced this pull request Dec 26, 2023
Involves:
- Home page
- relate posts
- search results
- feed
meiadvanture added a commit to meiadvanture/meiadvanture.github.io that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants