-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to search result overflow #51
Fix to search result overflow #51
Conversation
Sorry, I'm not sure what is meant by “when using code markdown early in the post”, could you please provide more details on how to reproduce the bug? (Maybe just paste a code snippet down below) |
Sure, sorry for being unclear! :) If I create a post and add this code snippet as the first thing in the post the search result preamble/description will then add the snippet row number as one long word and therefore break the design. Hope this made it a bit clearer! // EmailInput wraps an HTML `input` and adds some app-specific styling.
const EmailInput = React.forwardRef((props, ref) => (
<input ref={ref} {...props} type="email" className="AppEmailInput"></input>
));
class App extends Component {
emailRef = React.createRef();
// `this.emailRef.current` points to the `input` component inside of EmailInput,
// because EmailInput is forwarding its ref via the `React.forwardRef` callback.
onClickButton() {
this.emailRef.current.focus();
}
render() {
return (
<div>
<EmailInput ref={this.emailRef} />
<button onClick={() => this.onClickButton()}>
Click me to focus email
</button>
</div>
);
}
} |
I have combined your two commits into one (see 6fbebe3), thanks for the PR. |
Involves: - Home page - relate posts - search results - feed
Involves: - Home page - relate posts - search results - feed
* Fix to search result overflow
Involves: - Home page - relate posts - search results - feed
* Fix to search result overflow
Involves: - Home page - relate posts - search results - feed
* Fix to search result overflow
Involves: - Home page - relate posts - search results - feed
* Fix to search result overflow
Involves: - Home page - relate posts - search results - feed
Adds word break on search result page preamble, this bug is caused when using code markdown early in a post a can be seen in the screenshot below.