Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update english locales for recently updated posts #478

Merged
merged 1 commit into from
Jan 5, 2022
Merged

update english locales for recently updated posts #478

merged 1 commit into from
Jan 5, 2022

Conversation

joshjohanning
Copy link
Collaborator

@joshjohanning joshjohanning commented Jan 4, 2022

Description

This is a very minor wording fix/suggestion, but I think that it is more grammatically correct to say Recently Updated vs. Recent Update. Recent Update, to me, implies singularity whereas Recently Updated could imply single or multiple updated post(s).

I think Recently Updates could also work here, depending on preference, since it matches Tags and Table of Contents. But the problem would be if there are only 1 recently updated post, it would be dramatically incorrect.

Really splitting hairs here, but I made the change on my blog so thought I would contribute back.

Feel free to reject if you disagree! 🙂

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested

  • I have run bash ./tools/deploy.sh --dry-run (at the root of the project) locally and passed
  • I have tested this feature in the browser

Test Configuration

  • Browser type & version: Brave (chromium) 1.33.106
  • Operating system: macOS 11.6.3
  • Ruby version: ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-linux]
  • Bundler version: Bundler version 2.2.26
  • Jekyll version: * jekyll (4.2.1)

Checklist

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing 👍

@cotes2020 cotes2020 merged commit 4dd0c6d into cotes2020:master Jan 5, 2022
@cotes2020 cotes2020 added this to the 5.1.0 milestone Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants