Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline the mode-toggle when it receives keyboard focus #1690

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Outline the mode-toggle when it receives keyboard focus #1690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _includes/sidebar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ <h1 class="site-title">

<div class="sidebar-bottom d-flex flex-wrap align-items-center w-100">
{% unless site.theme_mode %}
<button type="button" class="btn" aria-label="Switch Mode" id="mode-toggle">
<button type="button" class="btn btn-link nav-link" aria-label="Switch Mode" id="mode-toggle">
<i class="fas fa-adjust"></i>
</button>

Expand Down
8 changes: 4 additions & 4 deletions _sass/addon/commons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,10 @@ $btn-mb: 0.5rem;
display: flex;
align-items: center;
justify-content: center;
box-shadow: var(--sidebar-border-color) 0 0 0 1px;

&:not(:focus-visible) {
box-shadow: var(--sidebar-border-color) 0 0 0 1px;
}

&:hover {
background-color: var(--sidebar-hover-bg);
Expand All @@ -845,9 +848,6 @@ $btn-mb: 0.5rem;
}

#mode-toggle {
padding: 0;
border: 0;

@extend %button;
@extend %sidebar-links;
@extend %sidebar-link-hover;
Expand Down