Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncating search #741

Closed
4 tasks done
joshjohanning opened this issue Oct 31, 2022 · 2 comments
Closed
4 tasks done

Truncating search #741

joshjohanning opened this issue Oct 31, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@joshjohanning
Copy link
Collaborator

Checklist

  • I have read the newlest tutorials and know the correct effect of the functional design.
  • There is no similar question on existing issues (including closed ones).
  • I have tried to find the answer on Jekyll Forum and StackOverflow.
  • My question is based on the latest code of the master branch.

Description

Hello,

I was wondering why in this issue #401 and commit fa333ef, the search results / truncation was fixed (from a user suggestion).

But in 5.3.1, we're truncating again (200). 647eea8

I was just curious if this was performance related or other?

Maybe it makes more sense to make this a configuration option and let users define if search results should have truncated posts, and if so, how much?

@cotes2020
Copy link
Owner

No need to add a config option, truncate it just to reduce the output of invisible content inside HTML, but I forgot the need for full-text search, will restore this feature later. 😂

@cotes2020 cotes2020 added the bug Something isn't working label Nov 4, 2022
cotes2020 added a commit that referenced this issue Nov 4, 2022
@joshjohanning
Copy link
Collaborator Author

thanks 😄

shihtiy-tw pushed a commit to shihtiy-tw/shihtiy-tw.github.io that referenced this issue Nov 26, 2022
linkliu pushed a commit to linkliu/game-tech-post-old that referenced this issue Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants