Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filtering column comparisons #599

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Fix filtering column comparisons #599

merged 1 commit into from
Nov 9, 2022

Conversation

Zhaars
Copy link
Contributor

@Zhaars Zhaars commented Nov 9, 2022

Added interface casting check on casting comparisonExpr.Left. to *sqlparser.ColName, which caused panic in non-column comparisons queries.

Checklist

@Zhaars
zhars/fix_filtering_column_comparisons
2417703 
Fixed getColumnEqualComparisonExprs function - added check on interface casting
@Zhaars Zhaars requested a review from Lagovas November 9, 2022 15:18
Lagovas
Lagovas approved these changes Nov 9, 2022
View reviewed changes
Copy link
Collaborator

@Lagovas Lagovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Zhaars Zhaars merged commit ebc364d into master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lagovas Lagovas Lagovas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zhaars @Lagovas