Add docker image for redis with ssl [2/3] #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add redis to generate_tls_certificates.sh script add dockerfile for future redis-ssl image with generated certs and tls support
extend namers with group part for ocsp/crl back previous names for ocsp/crl flags
shadinua
approved these changes
Aug 18, 2022
Zhaars
approved these changes
Aug 18, 2022
Co-authored-by: Dmytro Shapovalov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I added a new docker image for redis with ssl using pre-generated certificates. Also updated script that generates them and placed certs in tests/ssl as all other certs.
Also, deleted redundant
logsfile previously erroneously added.This PR doesn't touch any Acra's functionality and is intermediate for next PR which will add tls support for redis. And splitted to simplify reviewing step-by-step.
After creating new image repository and getting rights on our hub.docker.com, I will push new image.
P.S. this PR merges into #564 because it is intermediate for the next and last PR depends on #564 and this too. So, this PR will be merged after #564. And after merging last one, target branch will be changed to master.
Checklist
with new changes