[T2580] Fix handling null values in mysql #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G1gg1L3s
reviewed
May 23, 2022
Zhaars
reviewed
May 23, 2022
| @@ -196,6 +196,9 @@ func (wrapper *OldContainerDetectorWrapper) OnCryptoEnvelope(ctx context.Context | |||
|
|
|||
| // OnColumn callback which finds serializedContainer or AcraStruct/AcraBlock for backward compatibility | |||
| func (wrapper *OldContainerDetectorWrapper) OnColumn(ctx context.Context, inBuffer []byte) (context.Context, []byte, error) { | |||
| if inBuffer == nil { | |||
There was a problem hiding this comment.
but we return there inBuffer as is. Without allocating new buffer. If inBuffer in OnColumn will be nil, it will returned as is due to if len(inBuffer) < SerializedContainerMinSize
…ncoding-null-values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On decryption our envelope_detector returned
[]byte{}onnilvalues instead leavingnil. MySQL encoded differently empty strings and NULL values. NULL values should have 0xfb value. So on Acra side when it receive null value as 0xfb then it changed to empty array and encode it as LengthEncoded String or Integer that are incorrect.So in this PR removed processing null data in crypto envelope. If it will be empty array, it will be returned as empty array too.
Checklist
with new changes