Substitute oid in parse #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also brings new dependency - psycopg v3. This is a lot better version of psycopg2, with new supported features, like extended and prepared queries. In our case, we are interested in additional type parameters in a Parse packets, which psyco specifies by default.
Lagovas
reviewed
May 20, 2022
tests/test.py
Outdated
| @@ -10077,6 +10116,34 @@ async def test(): | |||
| loop.run_until_complete(test()) | |||
|
|
|||
|
|
|||
| class Psycopg3ExecutorMixin: | |||
| def setUp(self): | |||
There was a problem hiding this comment.
hm, I see such pattern not first time. So maybe we should introduce some Base class with such approach of initializing executors?) Like BaseExecutorInitialization and require to override get_executor method with proper class or correct configuration?) We can require to set class via class variable and introduce one more method get_executor_connection_args if some child class needs not common args.
There was a problem hiding this comment.
I don't quite understand how you see it. Can you provide an example of usage of such executor?
Beside that, the idea is cool!
Co-authored-by: Lagovas <[email protected]>
It is DB_PORT, not TEST_DB_PORT, oops :)
Replace $[0-9]+ with %s and place arguments in the correct order.
|
The broken tests are the result of T2568. The fix is at #542 |
* Extract base class from asyncpg3 mixin * Move executors to the top * Add asyncpg executor mixin * Add mysql executor mixin
Lagovas
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes substitution of OID in packets. Before, it substituted them in the data messages, which are returned by select. But there is another place where they can arrive - in parse packets. We missed it, because they are optional and most frontends do not specify them.
To test it, I've added a new dependency to our python tests - psycopg3. The first stable version was released on 2021-10-13, but I think we can start to use it because of its support of various features. For example in this case, this frontend sets the type of parameters in the parse packets. Also it helped to discover bug with encoding of i32, so in some cases tests could fall. I will fix it as soon as possible.
Checklist
Public API has proper documentation in the Acra documentation site or has PR on documentation repositorywith new changes
CHANGELOG.md is updated (in case of notable or breaking changes)Benchmark results are attached (if applicable)Example projects and code samples are up-to-date (in case of API changes)