Update python examples #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update python example
Lagovas
reviewed
Apr 18, 2022
| - column: data | ||
| data_type: bytes | ||
| # base64 bytes value |
There was a problem hiding this comment.
mention decoded value of base64 string to understand what we should expect: "test-data"
examples/python/example_with_zone.py
Outdated
| @@ -25,16 +25,16 @@ def print_data(zone_id, connection): | |||
| console""" | |||
| result = connection.execute( | |||
| # explicitly pass zone id before related data | |||
| select([cast(zone_id.encode('utf-8'), BYTEA), test_table])) | |||
| select([literal_column("'{}'".format(zone_id)), test_table])) | |||
There was a problem hiding this comment.
what about to avoid manual escaping values, use sqlalchemy's engine and specify type_ value for literal_column? I think that we can specify String type to apply escape rules for string values (according to TypeEngine documentation)?
if it will works, I prefer to use such approach. Because it will automatically work for mysql and all other DBs if we will add them.
There was a problem hiding this comment.
Sounds good, let me check it.
There was a problem hiding this comment.
I used sqlalchemy's literal, it performs escaping values inside. What do you think @Lagovas ?
Fixed after review
Lagovas
approved these changes
Apr 19, 2022
# Conflicts: # examples/python/encryptor_config_with_zone.yaml
Lagovas
pushed a commit
that referenced
this pull request
Apr 28, 2022
* zhars/update_python_examples Update python examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actualizing python examples.
encryptor_config_*with explicit table declaration to run with transparent encryption and be able to show type awareness functionalityzone_idfield to be able to match zone from the query but not from the table.write_datafunction with explicit zone_id literal - deletedcastoperator as it is not supported by Acra sql parser now.Checklist
with new changes