Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialization old containers on decryption fail #528

Merged
merged 5 commits into from
Apr 28, 2022

Conversation

Zhaars
Copy link
Contributor

@Zhaars Zhaars commented Apr 18, 2022

Acra should return pure old container as is in case of decryption failure. Currently, on newly found old container(AcraStruct/AcraBlock) Acra serialize it to general container to get corresponded handler during decryption, but in case of failure return general container which is not correct.

Note: Acra should return deserialized container only in case of pure AcraStruct/AcraBlock, in all other scenarios general container should be returned.

Checklist

Added deserialization of old container on decryption fail
@Zhaars Zhaars requested a review from Lagovas April 18, 2022 12:05
@Zhaars Zhaars merged commit a728f75 into master Apr 28, 2022
Lagovas pushed a commit that referenced this pull request Apr 28, 2022
* zhars/fix_deserializon_old_container_on_fail

Added deserialization of old container on decryption fail
@Lagovas Lagovas deleted the zhars/fix_deserializon_old_container_on_fail branch May 19, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants