Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default data type to unknown #520

Merged
merged 5 commits into from
Apr 6, 2022

Conversation

Lagovas
Copy link
Collaborator

@Lagovas Lagovas commented Apr 5, 2022

  • Use Unknown as default data_type
  • Add unit-tests that verifies that cannot be defined token_type together with data_type
  • move conversation from TokenType to EncryptedType from pseudonymization package to encryptor/config/common that responsible for EncryptedType

Checklist

Copy link
Contributor

@Zhaars Zhaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@G1gg1L3s G1gg1L3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@Lagovas Lagovas merged commit 6b57ad1 into master Apr 6, 2022
@Lagovas Lagovas deleted the lagovas/set-default-data-type-unknown branch April 6, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants