Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acra-censor: remove is forbidden #508

Merged
merged 5 commits into from
Mar 10, 2022
Merged

Conversation

G1gg1L3s
Copy link
Contributor

This removes unnecessary field IsForbidden from QueryInfo, which was used only in a couple of tests. This could potentially break the user API, so it is documented here.

Checklist

Currently, this is the only place that use it
This also updates tests that check for it
[skip ci]
Copy link
Collaborator

@Lagovas Lagovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gratz with the first PR) change version in the changelog and feel free to merge

CHANGELOG_DEV.md Outdated
@@ -1,3 +1,6 @@
## 0.92.0 - 2022-03-10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it's related to 0.93.0 )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops)

@G1gg1L3s G1gg1L3s merged commit 0ef657c into master Mar 10, 2022
@G1gg1L3s G1gg1L3s deleted the G1gg1L3s/T2423-remove-IsForbidden branch March 10, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants