regression tests for fixes in release/0.84.1 #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use separate ssl keys for tests
vixentael
approved these changes
Feb 1, 2019
| tlsConfig.ClientAuth = tls.NoClientCert | ||
| log.Warningln("Skip verifying TLS certificate, use for tests only!") | ||
| } | ||
| log.Infoln("Loaded tls config") |
There was a problem hiding this comment.
Suggested change
| log.Infoln("Loaded tls config") | |
| log.Infoln("Loaded TLS config") |
😁
decryptor/mysql/response_proxy.go
Outdated
| @@ -342,7 +342,8 @@ func (handler *Handler) ProxyClientConnection(errCh chan<- error) { | |||
| handler.setQueryHandler(handler.QueryResponseHandler) | |||
| break | |||
| case CommandStatementClose, CommandStatementSendLongData, CommandStatementReset: | |||
| fallthrough | |||
| clientLog.Debugln("Close|SendLongData|Reset command") | |||
| break | |||
|
great, so many tests now! |
Lagovas
commented
Feb 2, 2019
decryptor/mysql/response_proxy.go
Outdated
| @@ -342,7 +342,8 @@ func (handler *Handler) ProxyClientConnection(errCh chan<- error) { | |||
| handler.setQueryHandler(handler.QueryResponseHandler) | |||
| break | |||
| case CommandStatementClose, CommandStatementSendLongData, CommandStatementReset: | |||
| fallthrough | |||
| clientLog.Debugln("Close|SendLongData|Reset command") | |||
| break | |||
There was a problem hiding this comment.
Suggested change
| break |
There was a problem hiding this comment.
yeah, golang doesn't require break
There was a problem hiding this comment.
really?
my main concern was about the reason of changing logic – from "fallthrough" to "break"
There was a problem hiding this comment.
with fallthrough it will log that `unknown command with code XX. now it log specific names of commands as it was expected )
storojs72
approved these changes
Feb 4, 2019
Co-Authored-By: Lagovas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added regression tests for our fix in release/0.84.1 and some refactoring that was needed for it:
tests/docker/*.dockerfile) for databases with injected tls keys (tests/ssl/*) to correct use tls connections with all db drivers in integrations testsvar TestOnly = "false"variable in acra-server that was changed on compile time only for tests