T885 Add prepared statements support to sqlparser #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lagovas
requested changes
Jan 21, 2019
sqlparser/parse_test.go
Outdated
| testQueries := []string{ | ||
| `prepare stmt1 from 'select 1'`, | ||
| `prepare stmt1 from @variable`, | ||
| `prepare stmt1 from E'pg_escape_string'`, |
There was a problem hiding this comment.
it should not support this type of literals
|
@Lagovas @storojs72 are there fixes to be made for this PR to be complete? |
|
Yes, one more - to handle case of |
|
@Lagovas look please this PR once more from the beginning |
Lagovas
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PREPARE stmt_name FROM preparable_stmtstatment support;EXECUTE stmt_name [USING @var_name [, @var_name] ...]statement support;DEALLOCATE PREPARE stmt_namestatement support.