Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt cppcodec usage to current recommendations #289

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

jpetso
Copy link

@jpetso jpetso commented Nov 25, 2018

Hi there, cppcodec maintainer here. Thanks for using my library!

I released the 0.2 version a few months ago, which include a note that *_default_*.hpp includes are not recommended anymore and may be discontinued in the future. Not sure how popular your software is, but if you're going through the trouble of writing tutorials of your own, I think maybe I should try to update your examples, so people adopt the "right" way of doing things after looking at your README.

The good news is that you've already been using your own alias statements, like here:

using base64 = cppcodec::base64_rfc4648;
using hex = cppcodec::hex_lower;

The types on the right hand are provided by the header files of the same name, no *_default_* ones are required and the only change I'd make is adapting the actual include lines.

(I also took out the hex include from your README because you didn't use it in the example code. Let me know if this is wrong.)

Here's a patch to do this. The patch is trivial enough that I don't believe any of my copyright applies to it. (You look like you may be a commercial entity, so let's just get this out of the way.) I haven't built your software, but I'm pretty confident that it should continue working.

Cheers, and good luck with your project!

@vixentael
Copy link
Collaborator

vixentael commented Nov 25, 2018

Hi @jpetso!

First of all, thank you for cppcodec – your library is literally saving days of development! We use cppcodec to make it more simple for C++ developers to handle encryption<->encoding problems. These examples are 100% outside of commercial scope.

Thank you for your patch, I'll make sure that code builds, and merge it into master :)

@jpetso
Copy link
Author

jpetso commented Nov 25, 2018

Thanks @vixentael!

@vixentael vixentael changed the base branch from master to jpetso/cppcodec-update November 26, 2018 00:44
@vixentael vixentael merged commit 6b67948 into cossacklabs:jpetso/cppcodec-update Nov 26, 2018
@vixentael vixentael added the cpp label Nov 26, 2018
@vixentael
Copy link
Collaborator

vixentael commented Nov 26, 2018

Merged + update the version of cppcodec as well in #290.

And again, thank you, @jpetso ☀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants