transparent encryption on server side #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
in
|
vixentael
reviewed
Dec 14, 2018
| // in postgresql mode timeout used to stop listening connection in background goroutine | ||
| // and it's normal behaviour | ||
| continue | ||
| if pgProxy.TLSCh != nil { |
There was a problem hiding this comment.
avoid the second usage of this error after established TLS
vixentael
reviewed
Dec 14, 2018
| - data | ||
| - raw_data | ||
| encrypted: | ||
| - name: data |
vixentael
approved these changes
Dec 17, 2018
| return string(query[:len(query)-1]), nil | ||
| packet.logger.Debugln("GetParseQuery success") | ||
| return parse.QueryString(), nil | ||
| //query, err := FetchQueryFromParse(packet.descriptionBuf.Bytes()) |
| } | ||
| } | ||
|
|
||
| if len(insert.OnDup) > 0 { |
There was a problem hiding this comment.
what to do if database recognize duplication. it's like update on duplicate or upsert.
| changed := false | ||
| for _, expr := range exprs { | ||
| // recognize table name of column | ||
| if expr.Name.Qualifier.IsEmpty() { |
There was a problem hiding this comment.
first table is default table?
There was a problem hiding this comment.
yes. if multi-table update then if column without any table as prefix then work as it column from first table in the list
|
Looks awesome to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT not completed PR. I will add integration tests (now only unit-tests exists and I manually tested on local machine). But because it will huge part too, I decided to create PR before it for review less part of code and review general logic. I will push integration tests later before merging and one more review
features:
insert/updatequeries with encryption settings from config file (which key use to encrypt per table+column)insertstatements without list of columns before values (insert into table (col1, col2, col3)