-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump SDK to v0.45.9 and remove its own ics23 package and use c… #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaybxyz
changed the title
chore: bump SDk to v0.45.9 and remove its own ics23 package and use c…
chore: bump SDK to v0.45.9 and remove its own ics23 package and use c…
Oct 17, 2022
jaybxyz
force-pushed
the
bump-sdk-v0.45.9
branch
from
October 17, 2022 12:22
2f76a2c
to
7a11591
Compare
hallazzang
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jaybxyz
added a commit
that referenced
this pull request
Oct 18, 2022
#377) * chore: bump SDk to v0.45.9 and remove its own ics23 package and use cosmos-sdk ics23 * build: bump go version to 1.18 * chore: update version and upgrade go version in workflow actions * build: use new SDK version that is based v0.45.9 * fix: add validation check on match * build: use module golangci-lint and resolve lint issues * fix: use go install instead of go get (cherry picked from commit 043c8f9)
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps Cosmos SDK from v0.45.3 to v0.45.9.
Tasks
replace
directive to use../cosmos-sdk/ics23/go v0.8.0
go install
instead ofgo get
since we use go v1.18References
https://github.com/cosmos/gaia/tree/v7.1.0
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes