Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calculation bug of liquidstaking voting_power endpoint #342

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Jul 26, 2022

Description

Fixed a bug that missed the calculation of the voting power of the pool coin that was not in the user's balance when calculating the liquid stacking voting power at the /liquidstaking/v1beta1/voting_power/{voter} grpc endpoint

Fixed to create a bTokenSharePerPoolCoinMap for all pool coins before calculating the voting power for user's farming positions

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dongsam dongsam self-assigned this Jul 27, 2022
@dongsam dongsam added this to the v2.1.x milestone Jul 27, 2022
@dongsam dongsam force-pushed the fix-voting-power-endpoint-calculation-bug branch from ee556d2 to cd6862d Compare July 27, 2022 04:01
@dongsam dongsam force-pushed the fix-voting-power-endpoint-calculation-bug branch from cd6862d to a048288 Compare July 27, 2022 04:12
@dongsam dongsam marked this pull request as ready for review July 27, 2022 04:32
@jaybxyz jaybxyz self-requested a review July 27, 2022 06:51
Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hallazzang hallazzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongsam dongsam merged commit d9f3880 into main Jul 27, 2022
@dongsam dongsam removed the c-sync label Aug 25, 2022
dongsam pushed a commit that referenced this pull request Aug 31, 2022
fix: bug some pool coins voting power omitted on voting_powers #342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants