fix: return as many ticks as numTicks
in MakeOrderBookResponse
#333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
MakeOrderBookResponse
to return ticks by up tonumTicks
, which results in more predictable result.Currently, if
numTicks
was20
, only 20 ticks abovebasePrice
are scanned and included in the response, so if there were only 10 ticks that have order amount, the result includes 10 ticks.By changing that logic, from now on at most
numTicks
ticks with order amount will be included in the result, in given price range.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes