Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add liquidfarming module #332

Merged
merged 157 commits into from
Oct 5, 2022
Merged

feat: add liquidfarming module #332

merged 157 commits into from
Oct 5, 2022

Conversation

jaybxyz
Copy link
Contributor

@jaybxyz jaybxyz commented Jul 11, 2022

Description

This PR adds liquidfarming module.

closes: #331

Tasks

  • Scaffold liquidfarming module (define proto messages, define message types, keys, codec, params and etc)
  • Implement basic message server logic
  • Add CLI transaction commands
  • Add keeper test boilerplate (liquidity, farming modules)
  • Add necessary hooks in the farming module
  • Add AfterStaked hook to find the correct QueuedFarming and mint corresponding LFCoin
  • Add logics in PlaceBid and RefundBid
  • Add logics in AfterAllocateRewards hook
  • Add gRPC queries
  • Add CLI query commands
  • Add spec docs
  • Add Import / Export genesis
  • Refactor overall codebase
  • Add new message UnfarmAndWithdraw
  • Add test cases
  • Add CLI integration tests
  • Add simulation tests

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

jaybxyz added 27 commits June 28, 2022 13:38
1. LiquidFarm object doesn't need to be stored
2. Use param change proposal instead of a custom gov proposal
3. Clean up codebase
@jaybxyz jaybxyz self-assigned this Jul 11, 2022
@jaybxyz jaybxyz requested a review from dongsam as a code owner October 4, 2022 02:02
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@jaybxyz jaybxyz requested a review from hallazzang October 4, 2022 09:02
@jaybxyz jaybxyz requested a review from hallazzang October 4, 2022 11:14
@github-actions github-actions bot added the x/farm label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation x/farming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add liquidfarming module
4 participants