Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add marketmaker module #321

Merged
merged 6 commits into from
Aug 31, 2022
Merged

feat: add marketmaker module #321

merged 6 commits into from
Aug 31, 2022

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Jun 27, 2022 •
edited
Loading

Description

closes: #320

Tasks

  • spec
  • skeleton
  • core logics
  • proposal
  • test codes
  • validation
  • cli
  • invariant
  • simulation

References

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dongsam dongsam force-pushed the 320-mm-incentive branch from 675cc8a to c6d0ff4 Compare July 15, 2022 09:33
@dongsam dongsam force-pushed the 320-mm-incentive branch from c6d0ff4 to ae5c206 Compare July 20, 2022 04:00
@github-actions github-actions bot removed the c-sync label Jul 20, 2022
@dongsam dongsam added the c-sync label Jul 20, 2022
@github-actions github-actions bot removed the c-sync label Aug 10, 2022
@dongsam dongsam added the c-sync label Aug 10, 2022
@dongsam dongsam self-assigned this Aug 10, 2022
@github-actions github-actions bot removed the c-sync label Aug 10, 2022
@dongsam dongsam marked this pull request as ready for review August 16, 2022 13:20
@github-actions github-actions bot added c-sync documentation Improvements or additions to documentation labels Aug 29, 2022
jaybxyz
jaybxyz suggested changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@jaybxyz jaybxyz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on adding marketmaker module overall! I left some suggestions and comments below. Some of the comments are very nitpicking, so it is okay to ignore them if you don't like.

x/marketmaker/keeper/marketmaker.go Outdated Show resolved Hide resolved
x/marketmaker/keeper/marketmaker.go Outdated Show resolved Hide resolved
x/marketmaker/keeper/marketmaker.go Outdated Show resolved Hide resolved
x/marketmaker/keeper/marketmaker.go Outdated Show resolved Hide resolved
x/marketmaker/keeper/marketmaker.go Outdated Show resolved Hide resolved
x/marketmaker/keeper/proposal_handler.go Outdated Show resolved Hide resolved
x/marketmaker/keeper/proposal_handler.go Outdated Show resolved Hide resolved
x/marketmaker/client/cli/tx.go Outdated Show resolved Hide resolved
x/marketmaker/client/cli/tx.go Outdated Show resolved Hide resolved
x/marketmaker/client/cli/tx.go Outdated Show resolved Hide resolved
@dongsam dongsam requested a review from jaybxyz August 31, 2022 04:17
jaybxyz
jaybxyz approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongsam dongsam merged commit 92c5d23 into main Aug 31, 2022
@crypin crypin mentioned this pull request Aug 31, 2022
Merged
9 tasks
hallazzang
hallazzang reviewed Sep 1, 2022
View reviewed changes
Copy link
Contributor

@hallazzang hallazzang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, requesting some changes.

x/marketmaker/client/cli/query.go Show resolved Hide resolved
x/marketmaker/client/cli/query.go Show resolved Hide resolved
x/marketmaker/client/cli/query.go Show resolved Hide resolved
x/marketmaker/client/cli/tx.go Show resolved Hide resolved
x/marketmaker/keeper/marketmaker.go Show resolved Hide resolved
x/marketmaker/keeper/marketmaker.go Show resolved Hide resolved
x/marketmaker/simulation/decoder.go Show resolved Hide resolved
x/marketmaker/spec/06_params.md Show resolved Hide resolved
x/marketmaker/spec/05_events.md Show resolved Hide resolved
x/marketmaker/spec/07_proposal.md Show resolved Hide resolved
dongsam added a commit that referenced this pull request Sep 1, 2022
@dongsam
refactor: apply suggestions from #321
e160034
@dongsam dongsam mentioned this pull request Sep 1, 2022
Merged
12 tasks
@dongsam
Copy link
Contributor Author

dongsam commented Sep 1, 2022

@hallazzang Thanks for the review, all of the suggestions applied on #353

@dongsam dongsam removed the c-sync label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallazzang hallazzang hallazzang left review comments

@jaybxyz jaybxyz jaybxyz approved these changes

Assignees

@dongsam dongsam

Labels
documentation Improvements or additions to documentation x/marketmaker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add marketmaker module
3 participants
@dongsam @hallazzang @jaybxyz