Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: emit events for order trading volume #310

Merged
merged 6 commits into from
May 11, 2022
Merged

feat: emit events for order trading volume #310

merged 6 commits into from
May 11, 2022

Conversation

jaybxyz
Copy link
Contributor

@jaybxyz jaybxyz commented May 9, 2022 •
edited
Loading

Description

closes: #309

Tasks

  • Add events for order trading volume
  • Update spec docs

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jaybxyz jaybxyz self-assigned this May 9, 2022
@jaybxyz jaybxyz marked this pull request as ready for review May 11, 2022 04:27
hallazzang
hallazzang requested changes May 11, 2022
View reviewed changes
x/liquidity/keeper/swap.go Outdated Show resolved Hide resolved
x/liquidity/keeper/swap.go Outdated Show resolved Hide resolved
x/liquidity/keeper/swap.go Show resolved Hide resolved
x/liquidity/spec/07_events.md Outdated Show resolved Hide resolved
x/liquidity/types/events.go Outdated Show resolved Hide resolved
x/liquidity/types/events.go Outdated Show resolved Hide resolved
@jaybxyz jaybxyz requested a review from hallazzang May 11, 2022 05:52
@jaybxyz jaybxyz merged commit 919839a into main May 11, 2022
@queencre queencre mentioned this pull request May 11, 2022
Merged
9 tasks
@hallazzang hallazzang mentioned this pull request May 11, 2022
Closed
@dongsam dongsam removed the c-sync label May 16, 2022
@jaybxyz jaybxyz deleted the kogisin/309-add-order-filled-events branch October 27, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongsam dongsam dongsam approved these changes

@hallazzang hallazzang Awaiting requested review from hallazzang hallazzang is a code owner

Assignees

@jaybxyz jaybxyz

Labels
x/liquidity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit events for order trading volume
3 participants
@jaybxyz @dongsam @hallazzang