Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: register MsgServer in AppModule #210

Merged
merged 2 commits into from
Feb 24, 2022
Merged

fix: register MsgServer in AppModule #210

merged 2 commits into from
Feb 24, 2022

Conversation

hallazzang
Copy link
Contributor

Description

This PR fixes a minor bug in two modules, x/claim and x/liquidity, that is not registering a MsgServer inside the AppModule interface.

@hallazzang hallazzang self-assigned this Feb 23, 2022
dongsam
dongsam requested changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think RegisterMsgServer for liquidstaking also omitted, Could you add this also?

@hallazzang
Copy link
Contributor Author

@dongsam I forgot that. I've added a new commit, and going to merge this PR.

@dongsam dongsam self-requested a review February 24, 2022 09:22
@hallazzang hallazzang merged commit c0e414a into main Feb 24, 2022
@hallazzang hallazzang deleted the register-msg-server branch February 28, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongsam dongsam dongsam approved these changes

@jaybxyz jaybxyz Awaiting requested review from jaybxyz

Assignees

@hallazzang hallazzang

Labels
x/claim x/liquidity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hallazzang @dongsam