Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At AIB we worked a little bit on the sdk47/ibc-v7 migration for this repository, but then you preferred to do it on your own. Anyway, since you just merged it #918, I took the time to compare our changes and yours and I found a small list of things that could be cleaned/improved/fixed :
simulation
migration :ProposalContents
can be deleted if the module has no proposal messages or proposal content to be tested by simulation.govv1.ParamKeyTable()
bygov.ProvideKeyTable()
ante.DeductFeeDecorator
. Probably the most important one, I don't think it's OK to call this ante two times for each block.Let's discuss if you prefer to have this in separate PRs or if some of them are not correct/well-suited.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change