Doc for contributing guidelines #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaspitz
commented
Feb 28, 2023
yaruwangway
reviewed
Feb 28, 2023
| Incrementing a MINOR version number indicates that a PR is only consensus breaking to the provider, or only to the consumers. Be careful in this scenario, as state-transition changes to the provider can often lead to differences in how validator set changes are relayed to the consumers. | ||
|
|
||
| Incrementing a PATCH version number indicates that a PR is not consensus breaking to the provider or consumers. | ||
|
|
There was a problem hiding this comment.
for api breaking, it goes to patch ?
There was a problem hiding this comment.
For node API changes, yes
shaspitz
requested review from
jtremback,
mpoke,
sainoe,
MSalopek,
mmulji-ic and
glnro
as code owners
shaspitz
commented
Feb 28, 2023
mpoke
reviewed
Mar 1, 2023
Co-authored-by: Marius Poke <[email protected]>
…ain-security into contributing-docs
mpoke
approved these changes
Mar 3, 2023
sainoe
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds guidelines for contributing to ICS, along with a way that we could start incorporating semantic versioning into the repo.
See https://github.com/cosmos/gaia/blob/main/CONTRIBUTING.md#pull-requests and https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md for examples from sdk and gaia.
Linked issues
Automation for semver is tracked as #748
Type of change
Docs: Adds documentationRegression tests
n/a
New behavior tests
n/a