add additional checks for equivocation governance proposals #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSalopek
commented
Feb 10, 2023
MSalopek
requested review from
jtremback,
mpoke,
sainoe,
shaspitz,
mmulji-ic,
glnro and
yaruwangway
as code owners
MSalopek
changed the title
shaspitz
approved these changes
Feb 10, 2023
shaspitz
reviewed
Feb 10, 2023
shaspitz
reviewed
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds additional checks regarding Equivocation governance proposals.
Any time a validator double signs on any of the consumer chains, the provider will keep a record that signifies that an equivocation slash packet was received from a consumer chain.
Any proposals made to slash validators for which the provider does not have a double signing record will be rejected.
Linked issues
Closes: #729
Type of change
If you've checked more than one of the first three boxes, consider splitting this PR into multiple PRs!
Feature: Changes and/or adds code behavior, irrelevant to bug fixesFix: Changes and/or adds code behavior, specifically to fix a bugRefactor: Changes existing code style, naming, structure, etc.Testing: Adds testingDocs: Adds documentationNew behavior tests
Throttling e2e tests, unittests and integration tests were written to accomodate these changes.