Fix slash acks bug #708
Merged
Fix slash acks bug #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaspitz
added
the
type: bug
shaspitz
commented
Feb 4, 2023
shaspitz
requested review from
jtremback,
mpoke,
sainoe,
MSalopek,
mmulji-ic,
glnro and
yaruwangway
as code owners
5 tasks
6 tasks
shaspitz
added a commit
that referenced
this pull request
Feb 6, 2023
* disable consumer initiating slashing; also jailing for double-signing on the consumers * fix diff testing * fix TestHandleSlashPacket * fix relay tests * set jailUntil again * rm TestSlashUndelegation * rm unused func * change e2e test to check downtime * comments * split out TestRelayAndApplySlashPacket * final fix in slashing.go * fix TestHandleSlashPacket * expectJailing bool * fix throttle e2e tests * doc diff test * fix diff-test slashing * upstream new traces * update integration tests with new consumer initiated slash behaviour (#705) * Update tests/difference/core/model/src/model.ts * Update tests/difference/core/model/src/model.ts * rm comment * fix bug in diff-test model * Fix slash acks bug (#708) * refactor Slash processing on provider and consumer * add unittest for slash acks correctness * update using review comments * fix and tests * relay test * smol --------- Co-authored-by: Matija Salopek <[email protected]> Co-authored-by: MSalopek <[email protected]> * fix comment strings in integration tests --------- Co-authored-by: mpoke <[email protected]> Co-authored-by: Shawn Marshall-Spitzbart <[email protected]> Co-authored-by: MSalopek <[email protected]> Co-authored-by: Matija Salopek <[email protected]> Co-authored-by: Jehan <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #694. Please do not merge until #692 is merged!
Linked issues
Closes: #693
Type of change
Feature: Changes and/or adds code behavior, irrelevant to bug fixesFix: Changes and/or adds code behavior, specifically to fix a bugRefactor: Changes existing code style, naming, structure, etc.Testing: Adds testingDocs: Adds documentationRegression tests
TestRelayAndApplyDowntimePacketwas refactored to make sure that the consumer's outstanding downtime flag is properly deletedNew behavior tests
TestHandleSlashPacketnow has functionality for checking slash acks