Throttle integration test fixes #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaspitz
commented
Feb 1, 2023
| @@ -1236,6 +1236,8 @@ func (tr TestRun) waitForSlashThrottleDequeue( | |||
|
|
|||
| time.Sleep(500 * time.Millisecond) | |||
| } | |||
| // Sleep 20 seconds to pass a block, allowing the jailing to be incorporated into voting power | |||
There was a problem hiding this comment.
@MSalopek depending on block time when running in the cloud, this may need to be adjusted
shaspitz
requested review from
jtremback,
mpoke,
sainoe,
MSalopek,
mmulji-ic,
glnro and
yaruwangway
as code owners
MSalopek
approved these changes
Feb 1, 2023
|
BTW I just tried running the same test with a longer replenish period, and longer timeout. The test still passes if the ie. with a replenish period of 20 seconds and a block time of 20 seconds, throttling will act no different than allowing a packet to be handled once per block. This is why #684 was not caught by integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The diffs in #687 caused integration tests to fail, which is actually good and proves that the patch changed behavior. This PR fixes integration tests to be a bit more granular with the throttle behavior that's expected.
Type of change
Testing: Adds testingNew Behavior Testing
Full integration tests pass locally for me,
make test-integration