Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewErrorAcknowledgement with non-determinsitic error message #591

Merged
merged 1 commit into from
Dec 13, 2022
Merged

NewErrorAcknowledgement with non-determinsitic error message #591

merged 1 commit into from
Dec 13, 2022

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Dec 13, 2022 •
edited by MSalopek
Loading

Description

Do not pass non-determinsitic error message to NewErrorAcknowledgement

Linked issues

Closes: #590

Type of change

  • Non-breaking changes

Checklist:

  • Relevant issus are linked
  • Tests are passing (make test)
  • PR satisfies closing criteria defined in issue (remove if not applicable or issue has no criteria)

@mpoke mpoke changed the title do not pass non-determ error NewErrorAcknowledgement with non-determinsitic error message Dec 13, 2022
colin-axner
colin-axner approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@shaspitz shaspitz merged commit 0156424 into main Dec 13, 2022
@shaspitz shaspitz deleted the marius/590-err-ack branch December 13, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@shaspitz shaspitz shaspitz approved these changes

@jtremback jtremback Awaiting requested review from jtremback

@sainoe sainoe Awaiting requested review from sainoe

@danwt danwt Awaiting requested review from danwt

@MSalopek MSalopek Awaiting requested review from MSalopek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NewErrorAcknowledgement with non-determinsitic error message
3 participants
@mpoke @colin-axner @shaspitz