Minor refactor: factor out Begin(End)Block calls from simibc #588
Conversation
danwt
requested review from
jtremback,
mpoke,
sainoe and
shaspitz
as code owners
danwt
changed the title
Yes, if you write a test and what to check the state that was actually going into the blockchain, this is exactly the committed state. But to write the test you probably want to use This is used in the difftests |
| tmproto "github.com/tendermint/tendermint/proto/tendermint/types" | ||
| ) | ||
|
|
||
| func BeginBlock(c *ibctesting.TestChain, dt time.Duration) { |
There was a problem hiding this comment.
Add a comment explaining what the function does, especially the dt param.
|
|
||
| c.LastHeader = c.CurrentTMClientHeader() | ||
|
|
||
| // Store header to be used in UpdateClient |
| } | ||
|
|
||
| // Commit packets emmitted up to this point |
Description
This is a pure refactors that extracts BeginBlock and EndBlock methods from simibc to make them useable in other contexts
Type of change
Please delete options that are not relevant.
How was the feature tested?
Checklist:
Please delete options that are not relevant.
make test)