Adds Cryptographic Identity utility for working with various keys ect #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwt
requested review from
jtremback,
mpoke,
sainoe and
shaspitz
as code owners
shaspitz
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
Great stuff! Could we delete this struct and it's below helper in this PR? Should be easily replaceable with your more extensive helpers
@smarshall-spitzbart for sure! How about letting this one in first, then I (or we) can make a pass over the codebase and use these utils in all the obvious places? |
Sure thing, a larger parse through the codebase would make sense when we have time 👍 , for now I've made #473 which removes only the helper I was referencing |
MSalopek
approved these changes
Nov 15, 2022
danwt
pushed a commit
that referenced
this pull request
Nov 16, 2022
commit fb83bb7 Author: MSalopek <[email protected]> Date: Tue Nov 15 22:54:06 2022 +0100 add multiple consumer chains in integration tests (#407) commit 33137b3 Author: Shawn Marshall-Spitzbart <[email protected]> Date: Tue Nov 15 12:05:45 2022 -0800 testutils refactors and cleanup (#472) * changes * mas * Update README.md * Update README.md * sorry for the friday night emails * Update instance_test.go * util naming commit 0096317 Author: Daniel T <[email protected]> Date: Tue Nov 15 19:24:40 2022 +0000 Adds Cryptographic Identity utility for working with various keys ect (#470) * Adds crypto.go Cryptographic Identity util * Changes mock to ibcmock Co-authored-by: Daniel <[email protected]> commit b10e132 Author: Shawn Marshall-Spitzbart <[email protected]> Date: Mon Nov 14 16:32:31 2022 -0800 circuit breaker params (#444) * changes * Update params.go commit df53566 Author: Shawn Marshall-Spitzbart <[email protected]> Date: Mon Nov 14 16:11:22 2022 -0800 Slashing related e2e test improvements (#461)
danwt
added a commit
that referenced
this pull request
Nov 16, 2022
Squashed commit of the following: commit fb83bb7 Author: MSalopek <[email protected]> Date: Tue Nov 15 22:54:06 2022 +0100 add multiple consumer chains in integration tests (#407) commit 33137b3 Author: Shawn Marshall-Spitzbart <[email protected]> Date: Tue Nov 15 12:05:45 2022 -0800 testutils refactors and cleanup (#472) * changes * mas * Update README.md * Update README.md * sorry for the friday night emails * Update instance_test.go * util naming commit 0096317 Author: Daniel T <[email protected]> Date: Tue Nov 15 19:24:40 2022 +0000 Adds Cryptographic Identity utility for working with various keys ect (#470) * Adds crypto.go Cryptographic Identity util * Changes mock to ibcmock Co-authored-by: Daniel <[email protected]> commit b10e132 Author: Shawn Marshall-Spitzbart <[email protected]> Date: Mon Nov 14 16:32:31 2022 -0800 circuit breaker params (#444) * changes * Update params.go commit df53566 Author: Shawn Marshall-Spitzbart <[email protected]> Date: Mon Nov 14 16:11:22 2022 -0800 Slashing related e2e test improvements (#461) Co-authored-by: Daniel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a utility set that I extracted from working on Key Assignment.
It gives a really handy way to get all the various key and address types used by the sdk and tendermint, and their various interfaces, without having to piece everything together each time.
This is used extensively in the Key Assignment tests but I've opened this PR to get it in sooner, so that I can start using it to improve the diff tests ect.