add event emissions to provider and consumer #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSalopek
added
type: feature-request
MSalopek
commented
Nov 2, 2022
MSalopek
commented
Nov 2, 2022
MSalopek
force-pushed
the
masa/356-add-events
branch
from
44fa19e to
8ebb7bc
Compare
MSalopek
requested review from
jtremback,
mpoke,
sainoe and
danwt
as code owners
MSalopek
force-pushed
the
masa/356-add-events
branch
from
4ec552a to
5cd18e7
Compare
MSalopek
changed the title
MSalopek
force-pushed
the
masa/356-add-events
branch
from
2af0044 to
40f122b
Compare
danwt
approved these changes
Nov 11, 2022
x/ccv/types/events.go
Outdated
| EventTypeFeeTransferChannelOpened = "fee_channel_opened" | ||
| EventTypeConsumerClientCreated = "consumer_client_created" | ||
|
|
||
| EventExecuteConsumerChainSlash = "execute_consumer_chain_slash" |
There was a problem hiding this comment.
Should line 12 have EventType as a prefix?
x/ccv/types/events.go
Outdated
Comment on lines
5
to
15
| EventTypeTimeout = "timeout" | ||
| EventTypePacket = "ccv_packet" | ||
| EventTypeChannelClose = "channel_closed" | ||
| EventTypeChannelEstablished = "channel_established" | ||
| EventTypeFeeTransferChannelOpened = "fee_channel_opened" | ||
| EventTypeConsumerClientCreated = "consumer_client_created" | ||
|
|
||
| EventExecuteConsumerChainSlash = "execute_consumer_chain_slash" | ||
| EventTypeFeeDistribution = "fee_distribution" | ||
| EventTypeSendSlashPacket = "send_slash_packet" | ||
| EventTypeSendMaturedVSCPacket = "send_matured_vsc_packet" |
There was a problem hiding this comment.
Some of these are in past tense and some are in present tense, could it be more consistent?
By the way there is a nice vscode extension change-case which lets you easily change Camel to snake ect. Some of these dont match (ChannelClose = "channel_closed")
There was a problem hiding this comment.
Changed cases that did not match.
shaspitz
reviewed
Nov 11, 2022
shaspitz
reviewed
Nov 11, 2022
shaspitz
reviewed
Nov 11, 2022
danwt
pushed a commit
that referenced
this pull request
Nov 14, 2022
commit 5dc2bbf Author: MSalopek <[email protected]> Date: Fri Nov 11 20:03:22 2022 +0100 add event emissions to provider and consumer (#427) * add todos for event emissions * introduce ccv_consumer_added, ccv_fee_channel_opened events * add vsc_first_packet event in consumer * add fee distribution event; small refactor * add slash request events * add pending slash request clearing events * move all events to ccv; add CreateClient event on provi * remove event addition TODO tags * update after reviews * small refactors * address review comments and refactor Co-authored-by: Daniel T <[email protected]> commit 8d158d9 Author: Shawn Marshall-Spitzbart <[email protected]> Date: Fri Nov 11 01:27:22 2022 -0800 Update CODEOWNERS (#466)
danwt
added a commit
that referenced
this pull request
Nov 14, 2022
commit 5dc2bbf Author: MSalopek <[email protected]> Date: Fri Nov 11 20:03:22 2022 +0100 add event emissions to provider and consumer (#427) * add todos for event emissions * introduce ccv_consumer_added, ccv_fee_channel_opened events * add vsc_first_packet event in consumer * add fee distribution event; small refactor * add slash request events * add pending slash request clearing events * move all events to ccv; add CreateClient event on provi * remove event addition TODO tags * update after reviews * small refactors * address review comments and refactor Co-authored-by: Daniel T <[email protected]> commit 8d158d9 Author: Shawn Marshall-Spitzbart <[email protected]> Date: Fri Nov 11 01:27:22 2022 -0800 Update CODEOWNERS (#466) Co-authored-by: Daniel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events added:
create_client(provider -> during CreateConsumerClient call)consumer_added(provider)execute_consumer_chain_slash(provider)fee_channel_opened(consumer)first_vsc_packet(consumer -> mainly for debugging so we know that first vsc was received)fee_distribution(consumer)send_slash_packet(consumer)send_matured_vsc_packet(consumer)