Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration tests - split steps; run in parallel #371

Merged
merged 13 commits into from
Oct 7, 2022
Merged

integration tests - split steps; run in parallel #371

merged 13 commits into from
Oct 7, 2022

Conversation

MSalopek
Copy link
Contributor

@MSalopek MSalopek commented Oct 4, 2022

Changes:

  • allow running integration tests in parallel (1 docker container per run).
  • de-couple default and democracy test runs
  • split steps into multiple files/functions
  • allow easy combining of step sequences
  • minor package refactoring

Integration tests can now be run in parallel.

This is achieved through TestRun configuration parameters.

  • you can provide new container and instance names
  • each test run will be executed within its own docker container

Related: #361

@MSalopek MSalopek added type: feature-request New feature or request improvement scope: testing Code review, testing, making sure the code is following the specification. labels Oct 4, 2022
@MSalopek MSalopek self-assigned this Oct 4, 2022
jtremback
jtremback reviewed Oct 4, 2022
View reviewed changes
tests/integration/main.go Outdated Show resolved Hide resolved
jtremback
jtremback approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@jtremback jtremback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with removal or explanation of that text file

@jtremback jtremback requested a review from shaspitz October 4, 2022 21:13
@shaspitz
Copy link
Contributor

shaspitz commented Oct 4, 2022

This would close #310

shaspitz
shaspitz suggested changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@shaspitz shaspitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Most important comment is that running integration tests with a local sdk path needs to work with this branch

tests/integration/config.go Outdated Show resolved Hide resolved
tests/integration/main.go Show resolved Hide resolved
tests/integration/main.go Outdated Show resolved Hide resolved
tests/integration/steps_downtime.go Outdated Show resolved Hide resolved
tests/integration/steps_start_consumer.go Outdated Show resolved Hide resolved
tests/integration/steps.go Outdated Show resolved Hide resolved
shaspitz
shaspitz reviewed Oct 6, 2022
View reviewed changes
tests/integration/actions.go Outdated Show resolved Hide resolved
tests/integration/config.go Show resolved Hide resolved
MSalopek
MSalopek commented Oct 6, 2022
View reviewed changes
tests/integration/actions.go Outdated Show resolved Hide resolved
shaspitz
shaspitz approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@shaspitz shaspitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

tests/integration/main.go Show resolved Hide resolved
@shaspitz shaspitz merged commit 3f2091e into main Oct 7, 2022
@shaspitz shaspitz deleted the masa/361-more-tests branch October 7, 2022 16:41
@shaspitz shaspitz mentioned this pull request Oct 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtremback jtremback jtremback approved these changes

@shaspitz shaspitz shaspitz approved these changes

@mpoke mpoke Awaiting requested review from mpoke

@sainoe sainoe Awaiting requested review from sainoe

@danwt danwt Awaiting requested review from danwt

Assignees

@MSalopek MSalopek

Labels
scope: testing Code review, testing, making sure the code is following the specification. type: feature-request New feature or request improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MSalopek @shaspitz @jtremback @danwt