chore: bump cosmos-sdk and ibc-go to latest #2053
Conversation
WalkthroughWalkthroughThe recent updates primarily involve version bumps for various dependencies, including Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
MSalopek
added
scope: cosmos-sdk
| @@ -7,8 +7,8 @@ require ( | |||
| cosmossdk.io/math v1.3.0 | |||
| github.com/cometbft/cometbft v0.38.9 | |||
There was a problem hiding this comment.
CometBFT v.038.10 just came out as well.
There was a problem hiding this comment.
@insumity After some testing I learned that this bump does not work with cosmos-sdk and ibc-go because they haven't upgraded to use it. Additionally, hermes encounters weird deserialization errors, even on the latest version (v1.10.0). This was discovered during e2e testing.
We cannot bump comet at this point.
MSalopek
changed the title
MSalopek
force-pushed
the
chore/bump-sdk-ibc
branch
from
1dd6916
to
cdb20f4
Compare
MSalopek
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (3)
Dockerfile (1)
Line range hint
1-31: General Dockerfile ReviewThe Dockerfile is well-structured, and the use of multi-stage builds is appropriate for optimizing build times and minimizing image sizes. However, consider adding comments to complex RUN commands for better maintainability.
+ # Adding comments for clarity + # RUN if [ -d "./cosmos-sdk" ]; then go mod edit -replace github.com/cosmos/cosmos-sdk=./cosmos-sdk; fi + # RUN go mod tidyAlso applies to: 33-64
Dockerfile.combined (1)
Line range hint
1-26: General Dockerfile ReviewThe Dockerfile is well-structured, and the use of multi-stage builds is appropriate. Consider adding comments to complex RUN commands for better maintainability.
+ # Adding comments for clarity + # RUN if [ -n "${GAIA_TAG}" ]; then git checkout "${GAIA_TAG}"; fi + # RUN go mod tidyAlso applies to: 28-64
Dockerfile.gaia (1)
Line range hint
1-63: General Dockerfile ReviewThe Dockerfile is well-structured, and the use of multi-stage builds is appropriate. Consider adding comments to complex RUN commands for better maintainability.
+ # Adding comments for clarity + # RUN git clone https://github.com/cosmos/gaia.git + # RUN make build
* chore: bump cosmos-sdk and ibc-go to latest * chore: update changelogs * bump hermes in dockerfiles (cherry picked from commit aeab025)
chore: bump cosmos-sdk and ibc-go to latest (#2053) * chore: bump cosmos-sdk and ibc-go to latest * chore: update changelogs * bump hermes in dockerfiles (cherry picked from commit aeab025) Co-authored-by: MSalopek <[email protected]>
* chore: bump cosmos-sdk and ibc-go to latest * chore: update changelogs * bump hermes in dockerfiles
Bump cosmos-sdk to
v0.50.8and ibc-go tov8.3.2.Summary by CodeRabbit
Dependencies
Docker
hermesimage version from 1.8.0 to 1.10.0 in various Dockerfiles.