Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing migration; use correct constant types #1757

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix: add missing migration; use correct constant types #1757

merged 1 commit into from
Apr 4, 2024

Conversation

MSalopek
Copy link
Contributor

@MSalopek MSalopek commented Apr 3, 2024 •
edited
Loading

Description

Closes: #1756

This PR adds missing migration for BlocksPerEpoch and fixes the bugs found in upgrade tests.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@MSalopek MSalopek self-assigned this Apr 3, 2024
@MSalopek MSalopek requested a review from a team as a code owner April 3, 2024 20:06
@github-actions github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Apr 3, 2024
sainoe
sainoe approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@sainoe sainoe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MSalopek MSalopek added this pull request to the merge queue Apr 4, 2024
@MSalopek MSalopek mentioned this pull request Apr 4, 2024
Merged
Merged via the queue into main with commit 84199d7 Apr 4, 2024
33 checks passed
@MSalopek MSalopek deleted the masa/migrate-epoch-params branch April 4, 2024 09:20
mergify bot pushed a commit that referenced this pull request Apr 4, 2024
@MSalopek @mergify
fix: add missing migration; use correct constant types (#1757)
86f3056 
(cherry picked from commit 84199d7)
mergify bot pushed a commit that referenced this pull request Apr 4, 2024
@MSalopek @mergify
fix: add missing migration; use correct constant types (#1757)
1cfe2b3 
(cherry picked from commit 84199d7)
This was referenced Apr 4, 2024
Merged
Merged
MSalopek added a commit that referenced this pull request Apr 5, 2024
@mergify @MSalopek
fix: add missing migration; use correct constant types (backport #1757)…
352a05d 
… (#1759)

fix: add missing migration; use correct constant types (#1757)

(cherry picked from commit 84199d7)

Co-authored-by: MSalopek <[email protected]>
MSalopek added a commit that referenced this pull request Apr 5, 2024
@mergify @MSalopek
fix: add missing migration; use correct constant types (backport #1757)…
9de8555 
… (#1760)

fix: add missing migration; use correct constant types (#1757)

(cherry picked from commit 84199d7)

Co-authored-by: MSalopek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainoe sainoe sainoe approved these changes

@bermuell bermuell bermuell approved these changes

@p-offtermatt p-offtermatt p-offtermatt approved these changes

Assignees

@MSalopek MSalopek

Labels
C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add migration for new ICS param (BlocksPerEpoch)
4 participants
@MSalopek @sainoe @bermuell @p-offtermatt