Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add getters for testing epochs in Gaia (backport #1739) #1749

Merged
merged 4 commits into from
Apr 8, 2024
Merged

test: Add getters for testing epochs in Gaia (backport #1739) #1749

merged 4 commits into from
Apr 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 3, 2024

Description

Add some getters in the integrations test suite to test ICS epochs in Gaia.

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
This is an automatic backport of pull request #1739 done by [Mergify](https://mergify.com).

@sainoe @mergify
test: Add getters for testing epochs in Gaia (#1739)
d0514af 
* add getter and setters for testing

* add docs

(cherry picked from commit 1a7d03c)
@mergify mergify bot requested a review from a team as a code owner April 3, 2024 07:27
@mergify mergify bot assigned sainoe Apr 3, 2024
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Apr 3, 2024
MSalopek
MSalopek approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to go in, otherwise this PR on gaia does not make sense (and it would not work):

@MSalopek MSalopek merged commit e6eed7e into release/v4.1.x Apr 8, 2024
16 checks passed
@MSalopek MSalopek deleted the mergify/bp/release/v4.1.x/pr-1739 branch April 8, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-offtermatt p-offtermatt p-offtermatt approved these changes

@MSalopek MSalopek MSalopek approved these changes

Assignees

@sainoe sainoe

Labels
C:Testing Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MSalopek @p-offtermatt @sainoe