Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add oldest_unconfirmed_vsc query #1740

Merged
merged 12 commits into from
Apr 2, 2024
Merged

feat: add oldest_unconfirmed_vsc query #1740

merged 12 commits into from
Apr 2, 2024

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Mar 28, 2024 •
edited
Loading

Description

Closes: #1263

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if the change is state-machine breaking
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! the type prefix if the change is state-machine breaking
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@mpoke mpoke requested a review from a team as a code owner March 28, 2024 18:32
@github-actions github-actions bot added C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler labels Mar 28, 2024
@mpoke mpoke changed the title feat: add FirstVscSendTimestamp query feat: add oldest_unconfirmed_vsc query Mar 28, 2024
p-offtermatt
p-offtermatt approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The change in formatting for logging in ibc_module seems reasonable to have in this PR since it's just a tiny nit

@mpoke mpoke enabled auto-merge April 2, 2024 10:52
@mpoke mpoke added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit 60c4fd0 Apr 2, 2024
19 checks passed
@mpoke mpoke deleted the marius/1263-oldest-vscpacket branch April 2, 2024 11:12
mergify bot pushed a commit that referenced this pull request Apr 2, 2024
@mpoke @mergify
feat: add oldest_unconfirmed_vsc query (#1740)
eed8121 
* fix logging in ibc_module.go

* update proto files

* add query to keeper

* add CLI query

* add changelog entry

* change name to oldest_unconfirmed_vsc

* update changelog entry

* fix error messages

* fix UT

* adding comment for clarity

* QueryOldestUnconfirmVsc -> QueryOldestUnconfirmedVsc

* improve UT

(cherry picked from commit 60c4fd0)

# Conflicts:
#	.changelog/v3.2.0/features/consumer/1164-provider-info-query.md
#	.changelog/v4.1.0/features/provider/1740-oldest-unconfirm-vsc-query.md
@mergify mergify bot mentioned this pull request Apr 2, 2024
Merged
21 tasks
mergify bot pushed a commit that referenced this pull request Apr 2, 2024
@mpoke @mergify
feat: add oldest_unconfirmed_vsc query (#1740)
faf6151 
* fix logging in ibc_module.go

* update proto files

* add query to keeper

* add CLI query

* add changelog entry

* change name to oldest_unconfirmed_vsc

* update changelog entry

* fix error messages

* fix UT

* adding comment for clarity

* QueryOldestUnconfirmVsc -> QueryOldestUnconfirmedVsc

* improve UT

(cherry picked from commit 60c4fd0)

# Conflicts:
#	.changelog/v3.2.0/features/consumer/1164-provider-info-query.md
@mergify mergify bot mentioned this pull request Apr 2, 2024
Merged
21 tasks
mpoke added a commit that referenced this pull request Apr 2, 2024
@mergify @mpoke
feat: add oldest_unconfirmed_vsc query (backport #1740) (#1744)
d7cb8b2 
* feat: add oldest_unconfirmed_vsc query  (#1740)

* fix logging in ibc_module.go

* update proto files

* add query to keeper

* add CLI query

* add changelog entry

* change name to oldest_unconfirmed_vsc

* update changelog entry

* fix error messages

* fix UT

* adding comment for clarity

* QueryOldestUnconfirmVsc -> QueryOldestUnconfirmedVsc

* improve UT

(cherry picked from commit 60c4fd0)

# Conflicts:
#	.changelog/v3.2.0/features/consumer/1164-provider-info-query.md
#	.changelog/v4.1.0/features/provider/1740-oldest-unconfirm-vsc-query.md

* update changelog entries

---------

Co-authored-by: Marius Poke <[email protected]>
mpoke added a commit that referenced this pull request Apr 2, 2024
@mergify @mpoke
feat: add oldest_unconfirmed_vsc query (backport #1740) (#1745)
f716502 
* feat: add oldest_unconfirmed_vsc query  (#1740)

* fix logging in ibc_module.go

* update proto files

* add query to keeper

* add CLI query

* add changelog entry

* change name to oldest_unconfirmed_vsc

* update changelog entry

* fix error messages

* fix UT

* adding comment for clarity

* QueryOldestUnconfirmVsc -> QueryOldestUnconfirmedVsc

* improve UT

(cherry picked from commit 60c4fd0)

# Conflicts:
#	.changelog/v3.2.0/features/consumer/1164-provider-info-query.md

* update changelog entries

---------

Co-authored-by: Marius Poke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-offtermatt p-offtermatt p-offtermatt approved these changes

@insumity insumity insumity approved these changes

Assignees
No one assigned
Labels
C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No query for oldest unconfirmed VSCPacket
3 participants
@mpoke @insumity @p-offtermatt