Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: do not scan the tests for security issues #1715

Merged
merged 2 commits into from
Apr 2, 2024
Merged

ci: do not scan the tests for security issues #1715

merged 2 commits into from
Apr 2, 2024

Conversation

insumity
Copy link
Contributor

@insumity insumity commented Mar 19, 2024 •
edited
Loading

Description

This PR excludes the tests directory from the Run Gosec Security Scanner to avoid cases where we have dubious failures.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@github-actions github-actions bot added the C:CI Assigned automatically by the PR labeler label Mar 19, 2024
@insumity insumity mentioned this pull request Mar 19, 2024
Merged
21 tasks
@insumity insumity changed the title first commit ci: do not scan the tests for security issues Mar 19, 2024
@insumity insumity marked this pull request as ready for review March 20, 2024 13:57
@insumity insumity requested a review from a team as a code owner March 20, 2024 13:57
p-offtermatt
p-offtermatt approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sainoe sainoe self-requested a review March 20, 2024 15:39
@sainoe sainoe self-assigned this Mar 20, 2024
@sainoe
Copy link
Contributor

sainoe commented Mar 20, 2024

LGTM. Could you backport it to the feat/partial-set-security branch :) ?

@mpoke mpoke added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit 29fb3fc Apr 2, 2024
14 of 15 checks passed
@mpoke mpoke deleted the insumity/small-fix branch April 2, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainoe sainoe sainoe approved these changes

@p-offtermatt p-offtermatt p-offtermatt approved these changes

Assignees

@sainoe sainoe

Labels
C:CI Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@insumity @sainoe @p-offtermatt @mpoke