Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix make issue #1681

Merged
merged 1 commit into from
Mar 5, 2024
Merged

build: fix make issue #1681

merged 1 commit into from
Mar 5, 2024

Conversation

bermuell
Copy link
Contributor

@bermuell bermuell commented Mar 4, 2024

Description

Closes: #XXXX

LATEST_RELEASE variable in makefile required to perform a git fetch to get required variable value.
This was executed for each make which is not necessary.
Fix is using 'lazy evaluation' to execute related commans only when variable is referenced.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@github-actions github-actions bot added C:Build Assigned automatically by the PR labeler C:CI Assigned automatically by the PR labeler labels Mar 4, 2024
@bermuell bermuell marked this pull request as ready for review March 4, 2024 21:43
@bermuell bermuell requested a review from a team as a code owner March 4, 2024 21:43
@bermuell bermuell added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit b99a681 Mar 5, 2024
16 checks passed
@bermuell bermuell deleted the bernd/fix-makefile branch March 5, 2024 08:28
insumity pushed a commit that referenced this pull request Mar 11, 2024
fix make/workflow issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Build Assigned automatically by the PR labeler C:CI Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants