Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix e2e tests for changeover #1595

Merged
merged 1 commit into from
Jan 26, 2024
Merged

test: Fix e2e tests for changeover #1595

merged 1 commit into from
Jan 26, 2024

Conversation

bermuell
Copy link
Contributor

@bermuell bermuell commented Jan 26, 2024 •
edited
Loading

Description

Closes: #1594

Fix e2e tests for chageover feature failing on nightly tests

tests pass running: go run ./tests/e2e/... -tc changeover

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@bermuell bermuell requested a review from a team as a code owner January 26, 2024 12:27
@bermuell bermuell self-assigned this Jan 26, 2024
@bermuell bermuell requested a review from MSalopek January 26, 2024 12:27
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Jan 26, 2024
@bermuell bermuell requested a review from p-offtermatt January 26, 2024 12:28
p-offtermatt
p-offtermatt approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bermuell bermuell added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit 92bdf48 Jan 26, 2024
20 checks passed
@bermuell bermuell deleted the bernd/1594-fix_e2e_changeover branch January 26, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-offtermatt p-offtermatt p-offtermatt approved these changes

@mpoke mpoke mpoke approved these changes

@MSalopek MSalopek Awaiting requested review from MSalopek

Assignees

@bermuell bermuell

Labels
C:Testing Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: e2e tests for changeover faililng on nightly
3 participants
@bermuell @mpoke @p-offtermatt