-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: e2e initialization #1486
test: e2e initialization #1486
Conversation
e441d2c
to
9724657
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, I really like particularly the way the test target abstracts away so much of the underlying logic.
Some comments, none too major, mostly about adding a bit of documentation.
Could you also please update https://github.com/cosmos/interchain-security/blob/bernd/1133-e2e-compatiblity-tests/tests/e2e/README.md#L14 to match the changed setup? Nothing major, but at least adjust file names
Hey, there's one more Gosec error, could you please fix it? :) https://github.com/cosmos/interchain-security/actions/runs/7489943947/job/20387679246?pr=1486#step:4:536 |
|
Thanks for this work! It's clear and well-integrated into the current infrastructure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I would like to have an option to use pre-built docker images that can just be pulled from a registry. That way we could avoid extraneous build steps an using git worktree.
The released versions don't change so it's safe to push docker images (eg v3.3.0 will never change, all changes will exist in subsequent versions such as v3.3.1, v3.4.0, v4.x.y etc)
Description
Closes: #1133
Infra work on e2e tests to support testruns against different versions of provider and consumer
Proposed solution allows to define provider version and consumer version to be build and runs local test cases
on the constructed target.
Note: dependeing on the selected versions the tests might fail due to required changes as transformations and not supported checks. A separate PR will be opened targeting compatiblity tests.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...