Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup ccv types #1350

Merged
merged 7 commits into from
Oct 12, 2023
Merged

refactor: cleanup ccv types #1350

merged 7 commits into from
Oct 12, 2023

Conversation

bermuell
Copy link
Contributor

@bermuell bermuell commented Oct 11, 2023 •
edited
Loading

Description

Closes: #1213

Refactor shared events, codecs and errors assign to consumer and provider dedicated types where possible
Please note that it was agreed to no add the split out of the expected_keepers.go in this PR.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release for both the consumer and provider

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@github-actions github-actions bot added C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler C:x/types Assigned automatically by the PR labeler labels Oct 11, 2023
@bermuell bermuell marked this pull request as ready for review October 11, 2023 15:44
@bermuell bermuell requested a review from a team as a code owner October 11, 2023 15:44
@bermuell bermuell self-assigned this Oct 11, 2023
@bermuell bermuell requested review from MSalopek and sainoe October 11, 2023 15:44
MSalopek
MSalopek approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please check if tc := tc is actually needed in some of the tests?
I think that becomes an issue only when you're storing pointers in arrays/slices. In the testcases you changed the slice contains objects, and not pointers to objects.

I could be wrong, but I played with this a bit:

go.mod Show resolved Hide resolved
x/ccv/provider/keeper/proposal_test.go Show resolved Hide resolved
p-offtermatt
p-offtermatt approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bermuell bermuell merged commit ad37bcd into main Oct 12, 2023
14 checks passed
@bermuell bermuell deleted the bernd/1213-cleanup_ccv_types branch October 12, 2023 08:53
MSalopek pushed a commit that referenced this pull request Dec 1, 2023
@bermuell @MSalopek
refactor: cleanup ccv types (#1350)
0cfc206 
* Cleanup codec
* Cleanup error
* go.mod tidy
* Cleanup events
* Moved errors
* Moved events
* Fix lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-offtermatt p-offtermatt p-offtermatt approved these changes

@MSalopek MSalopek MSalopek approved these changes

@sainoe sainoe Awaiting requested review from sainoe

Assignees

@bermuell bermuell

Labels
C:x/consumer Assigned automatically by the PR labeler C:x/provider Assigned automatically by the PR labeler C:x/types Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup x/ccv/types
3 participants
@bermuell @MSalopek @p-offtermatt