Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve logging in getValPower #1211

Merged
merged 13 commits into from
Aug 25, 2023
Merged

chore: improve logging in getValPower #1211

merged 13 commits into from
Aug 25, 2023

Conversation

p-offtermatt
Copy link
Contributor

Description

Closes: N/A

Related: #1205

The code this PR changes has unhelpful error messages. While debugging, I needed to add logging information here,
so I think it might be useful to have this information here with this PR.
This PR is not meant to fix all logging issues in the e2e tests, but just to improve this one particular part of the code where I encountered a problem.

  • Make logging of fatal errors more informative in getValPowers

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@p-offtermatt p-offtermatt requested a review from a team as a code owner August 18, 2023 17:04
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Aug 18, 2023
@p-offtermatt p-offtermatt marked this pull request as draft August 18, 2023 17:04
@p-offtermatt p-offtermatt marked this pull request as ready for review August 18, 2023 17:12
@p-offtermatt p-offtermatt assigned bermuell and shaspitz and unassigned bermuell Aug 18, 2023
Copy link
Contributor

@shaspitz shaspitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/e2e/state.go Outdated Show resolved Hide resolved
tests/e2e/state.go Outdated Show resolved Hide resolved
@p-offtermatt p-offtermatt merged commit d137d39 into main Aug 25, 2023
@p-offtermatt p-offtermatt deleted the ph/improve-logging branch August 25, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants