tests: regression tests for types sent over wire as json #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaspitz
commented
Jul 18, 2023
| // AcknowledgePacket is in reference to a packet originally sent from this (consumer) module. | ||
| packet := channeltypes.NewPacket( | ||
| packetData.GetBytes(), |
There was a problem hiding this comment.
Wrong type was previously used in this test. I've adjusted it to use the proper consumer packet data type
| @@ -48,11 +50,6 @@ func (mat VSCMaturedPacketData) ValidateBasic() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (mat VSCMaturedPacketData) GetBytes() []byte { | |||
There was a problem hiding this comment.
This and the other GetBytes methods should never be used. VSCMatured and SlashPacket data are both wrapped as ConsumerPacketData when sent over the wire. The ConsumerPacketData.GetBytes() method should be used and is tested in this PR
insumity
pushed a commit
that referenced
this pull request
Jul 24, 2023
* tests * linting is the most important part of programming --------- Co-authored-by: Marius Poke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests for the types that are sent over the wire with IBC as JSON bytes. These tests use a hardcoded expected JSON schema that should never change lest we break the wire.
Note I've cherry-picked these tests into
release/v1.0.xand they pass as expected, woot we haven't broken the wireAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...