fix!: revert recent consumer packet data changes #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaspitz
changed the title
|
Is this in |
MSalopek
previously approved these changes
Jul 17, 2023
shaspitz
commented
Jul 17, 2023
| @@ -606,9 +606,29 @@ func (k Keeper) getAndIncrementPendingPacketsIdx(ctx sdk.Context) (toReturn uint | |||
| return toReturn | |||
| } | |||
|
|
|||
| // GetPendingPackets returns ALL the pending CCV packets from the store | |||
| // GetPendingPackets returns ALL the pending CCV packets from the store without indexes. | |||
| func (k Keeper) GetPendingPackets(ctx sdk.Context) []ccv.ConsumerPacketData { | |||
There was a problem hiding this comment.
We could get rid of this method, it'd just make the PR a lot larger
insumity
pushed a commit
that referenced
this pull request
Jul 24, 2023
* revert changes * lint * Update CHANGELOG.md * wrapper type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1037 included the addition of an
idxfield to theccv.ConsumerPacketDatatype, see this comment. After developing more, it turns out the addition of the idx field breaks the wire, since the ConsumerPacketData type is used for JSON serialization here. This PR reverts the addition of the idx field to ConsumerPacketData.To allow pending packet deletion (by idx) in the consumer's
SendPacketsmethod, we introduce a new wrapper typeConsumerPacketDataWithIdxwhich is only used for the new keeper method,GetAllPendingPacketsWithIdx. This allows us to leaveccv.ConsumerPacketDataunchanged.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)CHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change