Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: reenable proper make proto-check #1117

Closed
wants to merge 1 commit into from

Conversation

shaspitz
Copy link
Contributor

@shaspitz shaspitz commented Jul 6, 2023

Description

@MSalopek pointed out that a recent addition to the .dockerignore file was the reason that the old "proper" way of running make proto-gen was not working. This PR simply:

Nice find Matija!

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@shaspitz shaspitz marked this pull request as ready for review July 6, 2023 03:58
@shaspitz shaspitz requested a review from a team as a code owner July 6, 2023 03:58
@shaspitz
Copy link
Contributor Author

shaspitz commented Jul 6, 2023

nvm still doesn't work GH workflow lol, not worth debugging anymore

@shaspitz shaspitz closed this Jul 6, 2023
@shaspitz shaspitz deleted the shawn/reenable-make-proto-check branch July 6, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant