Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement full-node for integration test queries #263

Closed
shaspitz opened this issue Aug 11, 2022 · 0 comments · Fixed by #367
Closed

Implement full-node for integration test queries #263

shaspitz opened this issue Aug 11, 2022 · 0 comments · Fixed by #367
Assignees
@MSalopek
Labels
scope: testing Code review, testing, making sure the code is following the specification.

Comments

@shaspitz
Copy link
Contributor

shaspitz commented Aug 11, 2022 •
edited
Loading

There are a lot of places within integration test code that validators are queried for chain state like so. Currently, the first validator in a config list fulfills these queries. However, as we add validator downtime testing, these queries can fail if the desired validator is not operational.

Solution: a dedicated non validating, full node should be spawned up for integration tests. This node will never be taken down during the test, and can fulfill all queries
@shaspitz shaspitz added the scope: testing Code review, testing, making sure the code is following the specification. label Aug 11, 2022
@jtremback jtremback mentioned this issue Aug 26, 2022
Merged
@shaspitz shaspitz mentioned this issue Sep 21, 2022
Closed
17 tasks
@MSalopek MSalopek self-assigned this Sep 27, 2022
MSalopek added a commit that referenced this issue Sep 28, 2022
@MSalopek
add quiery node to integration tests
b34dc07 
Closes: #263
@MSalopek MSalopek mentioned this issue Sep 29, 2022
Merged
MSalopek added a commit that referenced this issue Oct 3, 2022
@MSalopek
add quiery node to integration tests
ae528e8 
Closes: #263
jtremback added a commit that referenced this issue Oct 5, 2022
@MSalopek @jtremback @danwt
use dedicated query node for tx and query RPC (#367)
149b42e 
* add quiery node to integration tests

Closes: #263

* use query node for tx and query RPC

* ignore unused function declaration

* connect relayer query node instead of validator

* refactor integration test scripts after review

Co-authored-by: Jehan <[email protected]>
Co-authored-by: Daniel T <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSalopek MSalopek

Labels
scope: testing Code review, testing, making sure the code is following the specification.
Projects
No open projects
Replicated Security
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use dedicated query node for tx and query RPC cosmos/interchain-security
2 participants
@MSalopek @shaspitz